fix(preview): order previews by ID during pagination - #63249
Merged
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
bug
3. to review
joshtrichards
requested review from
come-nc and
icewind1991
and removed request for
a team
August 14, 2026 16:14
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
CarlSchwan
approved these changes
Aug 17, 2026
come-nc
approved these changes
Aug 18, 2026
This was referenced Aug 18, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure preview pagination is deterministic by ordering results by preview ID.
PreviewMapper::getPreviews()usesp.id > $lastIdas a cursor and limits each query to a fixed number of rows. Without an explicitORDER BY, SQL does not guarantee the order of returned rows.This can cause cursor-based cleanup to skip previews or process batches inconsistently.
Changes:
getPreviews()results byp.id ASC.mtimepredicate with theptable alias (not currently a problem since there's no overlapping joined column name, but makes the query clearer).TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)